Skip to content

659 gpr assert absl check #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented May 22, 2025

% cargo build
   Compiling grpcio-sys v0.13.0+1.56.2-patched (/home/nkurtov/code/grpc-rs/grpc-sys)
warning: [email protected]+1.56.2-patched: In file included from /usr/include/absl/log/internal/nullstream.h:37,
warning: [email protected]+1.56.2-patched:                  from /usr/include/absl/log/internal/check_op.h:40,
warning: [email protected]+1.56.2-patched:                  from /usr/include/absl/log/internal/check_impl.h:19,
warning: [email protected]+1.56.2-patched:                  from /usr/include/absl/log/absl_check.h:38,
warning: [email protected]+1.56.2-patched:                  from grpc_wrap.cc:71:
warning: [email protected]+1.56.2-patched: /usr/include/absl/strings/string_view.h:53:26: error: 'string_view' in namespace 'std' does not name a type
warning: [email protected]+1.56.2-patched:    53 | using string_view = std::string_view;
warning: [email protected]+1.56.2-patched:       |                          ^~~~~~~~~~~
warning: [email protected]+1.56.2-patched: /usr/include/absl/strings/string_view.h:53:21: note: 'std::string_view' is only available from C++17 onwards
warning: [email protected]+1.56.2-patched:    53 | using string_view = std::string_view;
warning: [email protected]+1.56.2-patched:       |                     ^~~

Nikolay Kurtov added 2 commits May 16, 2025 18:52
Added a fallback definition for GPR_ASSERT using <assert.h> to handle cases where it is not predefined. This ensures smoother compilation and avoids potential issues with missing assertions.

Signed-off-by: Nikolay Kurtov <[email protected]>
Signed-off-by: Nikolay Kurtov <[email protected]>
Copy link

ti-chi-bot bot commented May 22, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 76e1ae8 try using ABSL_CHECK. Fails to compile. Needs upgrading to C++14, if not to C++17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant