Skip to content

Add command line option "--windows" #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Add command line option "--windows" #334

merged 3 commits into from
Mar 26, 2021

Conversation

marchersimon
Copy link
Contributor

Description

I added the command line option "--windows", since the functionality already was there, just the option was missing.

Checklist

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
  • Extended the README / documentation, if necessary

I didn't modify any tests, since I don't know what I should change. Also I'm sorry if I made any mistakes, I hardly know any javascript.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, of course. I wonder why it wasn't there before, but I guess @agnivade will tell us.

@bl-ue bl-ue requested a review from agnivade March 13, 2021 20:52
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test please?

@marchersimon
Copy link
Contributor Author

I'm not entirely sure what you mean by test, but I just added it to functional-test.sh

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marchersimon

@agnivade agnivade merged commit 7e49dda into tldr-pages:master Mar 26, 2021
@marchersimon marchersimon deleted the add-windows-option branch March 26, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants