Skip update when page not found #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchersimon
reviewed
Nov 1, 2021
Co-authored-by: marchersimon <[email protected]>
…eComputing/tldr-node-client into skipUpdateWhenPageNotFound
…teWhenPageNotFound is set".
marchersimon
approved these changes
Nov 1, 2021
MasterOdin
approved these changes
Nov 1, 2021
Co-authored-by: Matthew Peveler <[email protected]>
Co-authored-by: Matthew Peveler <[email protected]>
owenvoke
approved these changes
Nov 2, 2021
|
@MasterOdin @owenvoke can we merge this? |
|
@marchersimon, I think so. I just left it as I don't really maintain the Node client. |
|
I think I was against this feature in the first place 😛 But now that it's there, we have obviously landed with a config knob to disable this. Thanks for the reviews everyone. |
|
When will a new version of |
|
I will have to publish it. But if you want to have it urgently, you can fetch from master by passing the git commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced new configuration variable
skipUpdateWhenPageNotFoundforconfig.jsonor.tldrrc. When this variable is set totrue, then upon a cache miss no (lengthy) cache update will be performed (on slower machines like a Raspberry Pi this update can take more than four minutes).Checklist
Please review this checklist before submitting a pull request.
npm run test:all)