Show error on failing to parse .tldrrc #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchersimon
reviewed
Nov 1, 2021
Co-authored-by: marchersimon <[email protected]>
MasterOdin
approved these changes
Nov 2, 2021
MasterOdin
changed the title
Co-authored-by: Matthew Peveler <[email protected]>
owenvoke
approved these changes
Nov 2, 2021
navarroaxel
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #365
Checklist
Please review this checklist before submitting a pull request.
npm run test:all)^^^ I am on such a bad connection right now, that I can't even do
npm installcorrectly. I need someone to check, review and enhance if needed. I've never worked with mocha before, so also please check the test I added. Maybe it would also be good to add a test that checks what happens if.tldrrcfile is missing.