Skip to content

kill: update French translation #16631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

DDjivan
Copy link

@DDjivan DDjivan commented May 27, 2025

Typo: "identifiant" and not "indentifiant"

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Typo: "identifiant" and not "indentifiant"
@CLAassistant
Copy link

CLAassistant commented May 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the translation edit Changes to an existing translation page(s). label May 27, 2025
Copy link
Collaborator

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastiaanspeck
Copy link
Member

Hello! I've noticed something unusual when checking this PR:

  • The page pages.fr/common/kill.md is outdated, based on number of commands, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

While touching this page, is this something you can fix as well?

@MachiavelliII
Copy link
Member

Great work

Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the page as well to reflect the English page again?

Copy link
Collaborator

@nicokosi nicokosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastiaanspeck
Copy link
Member

@DDjivan pinging you since there is no sign of activity for over a week. Any updates on this? I requested to add some missing examples as well.

@DDjivan
Copy link
Author

DDjivan commented Jun 8, 2025

@sebastiaanspeck Sorry, I just saw the replies! I'll do that right away

DDjivan added 2 commits June 8, 2025 11:42
Removed background job part 
Added backticks for SIGUSR1 at the last bullet
There was no translation of the Linux kill page 
Translated from the English Linux kill page, and not the English common kill page
@github-actions github-actions bot added the new translation PRs translating a page(s) from English to other languages. label Jun 8, 2025
@DDjivan
Copy link
Author

DDjivan commented Jun 8, 2025

Here's what I did:

  • pages.fr/common/kill.md had one more example than pages/common/kill.md, so I removed it;
  • pages/linux/kill.md didn't have a French equivalent in pages.fr, so I created pages.fr/linux/kill.md and made it accurate (especially in the number of commands).

I hope this is all good! Sorry again for the inactivity.

@tldr-bot

This comment has been minimized.

@sebastiaanspeck sebastiaanspeck changed the title kill: fix typo in French translation kill: update French translation Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new translation PRs translating a page(s) from English to other languages. translation edit Changes to an existing translation page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants