Skip to content

Add missing register_files APIs #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChillFish8
Copy link

This PR adds two missing ring calls, io_uring_register_files_tags and io_uring_register_files_update_tag.

Tests have been added and confirmed working, I also adjusted part of the docs for register_files to more accurately note the behaviour of the call.

@ChillFish8
Copy link
Author

ChillFish8 commented Jun 1, 2025

I thought I could get away with not waiting on the completions but I guess CI is just slow enough to run into the completions not being registered in time. Should be fixed now along with linting.

@ChillFish8
Copy link
Author

@quininer can you cancel the last run, it is deadlocked and will just be waiting forever, I've changed the way it waits for completions to use an event FD which should reliably wake up.

@ChillFish8
Copy link
Author

Hopefully the last fix on the tests 🤞

@quininer
Copy link
Member

quininer commented Jun 2, 2025

You can also create new IoUring instances for specific test cases.

@ChillFish8
Copy link
Author

I was hoping to avoid that, we can give it a go, but I believe it shouldn't be timing out the runners like that with the eventfd approach so will need to look into it a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants