Defend against parallel package builds via a file lock #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
commented
Oct 3, 2018
gaborbernat
force-pushed
the
1026
branch
2 times, most recently
from
0de3d69 to
83def3d
Compare
We create a hard link (if possible, otherwise copy of the built package) inside a temp folder. This way subsequent sessions are free to remove dist folder and we also guarantee that the built package during the build is what tox environments use (even if the package gets rebuilt in the meantime).
gaborbernat
force-pushed
the
1026
branch
15 times, most recently
from
9588075 to
8acf739
Compare
webknjaz
reviewed
Jun 28, 2020
|
|
||
| reader.addsubstitutions(distdir=config.distdir) | ||
| config.distshare = reader.getpath("distshare", dist_share_default) | ||
| self._make_thread_safe_path(config, "distshare", unique_id) | ||
| config.temp_dir = reader.getpath("temp_dir", "{toxworkdir}/.tmp") |
There was a problem hiding this comment.
@gaborbernat if I'm reading this right, you forgot to add it to substitutions
There was a problem hiding this comment.
This is meant as an internal implementation detail folder, not meant for public usage.
There was a problem hiding this comment.
Ah, the docs suggest otherwise...
There was a problem hiding this comment.
Well, I guess now it's supported.
webknjaz
added a commit
to webknjaz/tox
that referenced
this pull request
Jun 28, 2020
This change recovers a missing `temp_dir` substitution. The docs for it were added in tox-dev#1032 but it never actually worked. Fixes tox-dev#1608
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1026.