-
-
Notifications
You must be signed in to change notification settings - Fork 536
TOML set_env file support #3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOML set_env file support #3478
Conversation
10c8e9c
to
7dc1f78
Compare
set_env
from fileset_env
from file
You still plan to tackle this? |
@gaborbernat Yes I do. Sorry for the silence, I was unavailable for a couple of days. Updated PR should be available early next week. |
6fdde68
to
81a6997
Compare
@juditnovak tag me when ready 👍 |
@gaborbernat Sorry for the delay, the PR is ready. I keep thinking that I'm kind unhappy with the solution in terms of separation of concerns -- as part of the INI/TOML processing is happening on the level of each loader ( In case I'm overlooking a different, more elegant solution, feel free to let me know, and I'm glad to adjust. |
04b9290
to
e4cabe8
Compare
@gaborbernat The condition in question is removed (assuming that 'revert' meant removal of newly added code). |
Yeah, didn't forget about this, have the tab pinned. Just this week has been very busy at work and didn't get time to allocate to this, we should get this out by early next week though 👍 |
@gaborbernat Sure, thanks much for getting back. |
a683cfd
to
b339f50
Compare
Signed-off-by: Bernát Gábor <[email protected]>
b339f50
to
015cf6b
Compare
Fix released with https://github.com/tox-dev/tox/releases/tag/4.24.2 |
This code change is addressing #3474, making sure that TOML config has the same support to apply
set_env
from file, as INI configuration does.Resolves #3474