Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

[AP-806] Bump joblib to be python 3.8 compatible #35

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[AP-806] Bump joblib to be python 3.8 compatible #35

merged 1 commit into from
Oct 28, 2020

Conversation

koszti
Copy link
Contributor

@koszti koszti commented Oct 28, 2020

Problem

PPW is currently failing on python 3.8. More info at transferwise/pipelinewise-target-snowflake#99

Proposed changes

Bump the failing joblib to 0.16.0

Types of changes

What types of changes does your code introduce to PipelineWise?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@koszti koszti merged commit 1f4f47b into master Oct 28, 2020
@koszti koszti deleted the AP-806 branch October 28, 2020 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants