Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

AP-1039 Revamp CI #54

Merged
merged 10 commits into from
Aug 6, 2021
Merged

AP-1039 Revamp CI #54

merged 10 commits into from
Aug 6, 2021

Conversation

Samira-El
Copy link
Contributor

@Samira-El Samira-El commented Aug 6, 2021

Problem

  • Bye bye circleci
  • Pylint not happy
  • Uses nose for tests
  • No test coverage checks
  • No friendlier dev experience
  • both requirements file and setup.py exist

Proposed changes

  • Use GHA for CI
  • Use pytest for tests and set min coverage
  • Make pylint and pytest happy
  • Add docker-compose and Makefile for friendlier dev experience
  • Update readme
  • remove requirements file

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@Samira-El Samira-El merged commit e060d44 into master Aug 6, 2021
@Samira-El Samira-El deleted the AP-1039 branch August 6, 2021 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants