-
-
Notifications
You must be signed in to change notification settings - Fork 730
v3: prod worker graceful shutdown #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicktrn
commented
Apr 16, 2024
- Give workers 10 minutes to finish their current attempt when receiving SIGTERM
- Fail run with timeout error if it doesn't exit in that timeframe
- Fix an issue where large timeout delays could exceed 32 bit signed integer limits
🦋 Changeset detectedLatest commit: 44a1a92 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Some questions on this:
|
Should probably have prefaced this by stating the previous default, which was to quit immediately. This is more of a precaution to limit situations that are difficult to debug. With these changes we'll know when this happens, and we have control over the shutdown process.
Manually or automatically terminating containers / pods.
Worst case would be the entire run fails and has to be replayed. Could up the grace period to an hour for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one question