Skip to content

Trace view fixes and improvements #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 22, 2024
Merged

Trace view fixes and improvements #1046

merged 26 commits into from
Apr 22, 2024

Conversation

matt-aitken
Copy link
Member

CleanShot.2024-04-19.at.18.15.20.mp4

Fixes

  • Now the selected span doesn't add entries to the browser history
  • Now changing the selected span doesn't impact the tree view or scrolling
  • Clicking a node doesn't deselect it (even if it's already selected)

Improvements

  • The loader for the trace only gets used when the trace has changed (not when selecting a span)
  • Added a shortcuts bar at the bottom
  • Added expand and collapse all
  • Added number key shortcuts for expanding/collapsing at level
  • Added Option/Alt clicking of the chevron to expand/collapse at that level
  • Added Option/Alt + Left/Right to expand/collapse at that level

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 961fe70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken matt-aitken merged commit 3913e57 into main Apr 22, 2024
@matt-aitken matt-aitken deleted the fixes/trace-view branch April 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant