Skip to content

v3 CLI compiling E2E test suite #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

codenem
Copy link
Contributor

@codenem codenem commented May 28, 2024

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  1. Tested the modifications to the github workflows using act:

    act -W '.github/workflows/publish.yml' -j 'e2e' -P buildjet-8vcpu-ubuntu-2204=catthehacker/ubuntu:act-latest
  2. Tested that pnpm exec triggerdev dev still works on the v3-catalog project

TODO

  • Test that the pnpm exec triggerdev deploy still works on the v3-catalog project

Changelog

Added an E2E test suite for the v3 CLI deploy command, focusing on the bundling.
Please refer to the README.md.


Screenshots

Input

MOD=server-only PM=pnpm pnpm --filter trigger.dev run test:e2e

Output

Screenshot 2024-06-12 at 15 52 05

💯

Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 69ed24e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenem codenem force-pushed the cli-v3-integration-test-suite-setup branch 16 times, most recently from 9a7fd3d to abf297a Compare June 11, 2024 13:55
@codenem codenem force-pushed the cli-v3-integration-test-suite-setup branch 2 times, most recently from b9cc750 to 167543a Compare June 12, 2024 11:49
@codenem codenem changed the title Cli v3 integration test suite poc v3 CLI compiling E2E test suite Jun 12, 2024
@codenem codenem force-pushed the cli-v3-integration-test-suite-setup branch from 553fa38 to 44d946b Compare June 12, 2024 13:06
@codenem codenem marked this pull request as ready for review June 12, 2024 13:10
@ericallam ericallam force-pushed the cli-v3-integration-test-suite-setup branch from 466d940 to 69ed24e Compare June 14, 2024 10:25
@ericallam ericallam merged commit d4ccdf7 into triggerdotdev:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants