-
-
Notifications
You must be signed in to change notification settings - Fork 730
v3 CLI compiling E2E test suite #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericallam
merged 38 commits into
triggerdotdev:main
from
codenem:cli-v3-integration-test-suite-setup
Jun 14, 2024
Merged
v3 CLI compiling E2E test suite #1135
ericallam
merged 38 commits into
triggerdotdev:main
from
codenem:cli-v3-integration-test-suite-setup
Jun 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69ed24e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9a7fd3d
to
abf297a
Compare
b9cc750
to
167543a
Compare
553fa38
to
44d946b
Compare
466d940
to
69ed24e
Compare
ericallam
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Testing
Tested the modifications to the github workflows using act:
Tested that
pnpm exec triggerdev dev
still works on the v3-catalog projectTODO
pnpm exec triggerdev deploy
still works on the v3-catalog projectChangelog
Added an E2E test suite for the v3 CLI deploy command, focusing on the bundling.
Please refer to the README.md.
Screenshots
Input
Output
💯