Skip to content

Support custom queue when triggering a task #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2024
Merged

Conversation

matt-aitken
Copy link
Member

Closes #1137

When calling trigger or batchTrigger (and their await variants) you can pass in a custom queue. This wasn't properly supported before.

This PR includes a test script (queues) that can be run in the v3-catalog.

Copy link

changeset-bot bot commented May 30, 2024

🦋 Changeset detected

Latest commit: a65519b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matt-aitken matt-aitken requested a review from ericallam May 30, 2024 09:27
@ericallam ericallam force-pushed the fix/override-queue branch from 27efa88 to a65519b Compare May 31, 2024 10:20
@ericallam ericallam merged commit 51bb4c8 into main May 31, 2024
2 checks passed
@ericallam ericallam deleted the fix/override-queue branch May 31, 2024 10:24
jacobparis pushed a commit to jacobparis/trigger.dev that referenced this pull request Jun 1, 2024
* Created a v3-catalog test script for queues

* SDK: Fix for calling trigger and passing a custom queue

* Support custom queue in TriggerTaskService

* Improved the script in the catalog so it’s clearer what’s going on

* Remove the concurrencyLimit from a queue if the limit is null

* Fix for the test code… stupid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-2618] Overriding the queue when calling trigger/triggerAndWait isn't working
2 participants