Skip to content

fix: prevent filter tooltip from opening on autofocus #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix: prevent filter tooltip from opening on autofocus #1185

merged 3 commits into from
Jul 1, 2024

Conversation

kaiiiiiiiii
Copy link
Contributor

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

I navigated between pages and also did a couple of full page reloads.


Changelog

Change prevents the "Runs" filter tooltip from auto opening on a page reload or page navigation. Focus on the filter element is not affected.


Videos

Before:

before.mov

After:

after.mov

Pardon me if I missed anything, first project PR :)

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: f9a3da4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicktrn
Copy link
Collaborator

nicktrn commented Jun 25, 2024

Thanks for this @kaiiiiiiiii! I wonder if we need that autofocus here at all. Without it you can't press enter to open the menu, but the F shortcut works just fine. I think it looks a bit strange to have the filter button highlighted on entering the page. @matt-aitken?

@matt-aitken
Copy link
Member

We've just removed the autofocus instead

@matt-aitken matt-aitken merged commit 76a5c62 into triggerdotdev:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants