v3: Cancel awaited subtasks and reliable rate-limit recovery #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 202a2fb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericallam
force-pushed
the
v3/cancel-run-dependencies
branch
from
4f9b10a to
df20d43
Compare
- Changing from sliding window to token bucket in the API rate limiter, to help smooth out traffic - Adding spans to the API Client core & SDK functions - Added waiting spans when retrying in the API Client - Retrying in the API Client now respects the x-ratelimit-reset - Retrying ApiError’s in tasks now respects the x-ratelimit-reset - Added AbortTaskRunError that when thrown will stop retries - Added idempotency keys SDK functions and automatically injecting the run ID when inside a task - Added the ability to configure ApiRequestOptions (retries only for now) globally and on specific calls - Implement the maxAttempts TaskRunOption (it wasn’t doing anything before)
ericallam
force-pushed
the
v3/cancel-run-dependencies
branch
from
df20d43 to
edd6342
Compare
|
…ex on BatchTaskRun and TaskRun
matt-aitken
reviewed
Jul 5, 2024
Comment on lines
107
to
118
| const cancelService = new CancelTaskRunService(); | ||
|
|
||
| // Cancel any dependent task runs | ||
| for (const attempt of cancelledTaskRun.attempts) { | ||
| for (const dependency of attempt.dependencies) { | ||
| await cancelService.call(dependency.taskRun, { | ||
| ...opts, | ||
| reason: `Parent task run was cancelled`, | ||
| }); | ||
| } | ||
| } | ||
|
|
matt-aitken
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggerAndWaitorbatchTriggerAndWait), those subtasks will now also be cancelled (and any of their subtasks). Tasks triggered withtriggerorbatchTriggerwill not be cancelled.