-
-
Notifications
You must be signed in to change notification settings - Fork 731
Added extraCACerts config #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @gautamsi!
Good call with resolveConfig()
. I think it will be a lot cleaner doing everything in there, that is:
- Add the raw
extraCACerts
path toadditionalFiles
- Tranform it so
resolvedConfig.extraCACerts
now points at the deployed destination path ->/app/...
Re the last point: We could even just strip ..
and keep the path relative to /app
if NODE_EXTRA_CA_CERTS
works fine with relative paths. /app
is the work dir in the resulting image so that should be fine.
I will update this soon |
Thanks for the changes! Will get this merged and tested. Should be in the next release. |
verified beta-49 works with this feature :) |
I did test this locally briefly and relative paths work as well 👍 |
Closes #1210
✅ Checklist
Testing
extraCACerts
config./ca.crt
Changelog
Added config option
extraCACerts
toProjectConfig
type. This copies the ca file along withadditionalFiles
and setsNODE_EXTRA_CA_CERTS
environment variable in built image as well as running the task.Screenshots
[Screenshots]
💯