v3: fix websocket timeouts #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a117dcb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 9a6a7a2.
ericallam
reviewed
Jul 17, 2024
ericallam
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSockets could previously time out when no messages were sent for a period of 60s. This is due to load balancer connection timeouts. The only real fix here was to add a ping / pong mechanism that will keep connections alive during periods of rest, e.g. when waiting within or between attempts.
Pings will be automatically sent from the server every 45s. Clients will reply with pongs, but we just log those for now.
Whenever a dev CLI disconnects it will also cancel all in-progress dev runs. This shouldn't happen anymore.
This fix also prevents uncaught exceptions related to schema parsing.