Skip to content

When enqueuing clear concurrency for that run #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

matt-aitken
Copy link
Member

It was possible in some edge cases for the concurrency to be taken by a run and the message to get enqueued again without the original concurrency being cleared. This causes problems if you're maxed out with your concurrency (at the org, environment, or task/queue level).

The change here remove the concurrency keys when enqueuing, since obviously it's not running if we're enqueuing.

Copy link

changeset-bot bot commented Aug 25, 2024

⚠️ No Changeset found

Latest commit: 2ee3b7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 2ee3b7c

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1271
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1271
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1271
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1271

Open in Stackblitz

@matt-aitken matt-aitken merged commit 99a63d4 into main Aug 25, 2024
4 checks passed
@matt-aitken matt-aitken deleted the enqueue-clear-concurrency branch August 25, 2024 14:56
D-K-P pushed a commit that referenced this pull request Sep 9, 2024
* Better logging if a background worker isn’t created

* When enqueuing a message into the queue clear the concurrency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant