Skip to content

Fix "crypto is not defined error" on Node.js 18 in dev #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-cheetahs-scream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Add --experimental-global-webcrypto node option fix "crypto is not defined error" on Node.js 18 in dev
16 changes: 15 additions & 1 deletion packages/core/src/v3/build/runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ export function execOptionsForRuntime(runtime: BuildRuntime, options: ExecOption

const conditions = options.customConditions?.map((condition) => `--conditions=${condition}`);

return [importEntryPoint, conditions, process.env.NODE_OPTIONS]
return [
importEntryPoint,
conditions,
process.env.NODE_OPTIONS,
nodeRuntimeNeedsGlobalWebCryptoFlag() ? "--experimental-global-webcrypto" : undefined,
]
.filter(Boolean)
.flat()
.join(" ");
Expand All @@ -58,3 +63,12 @@ export function execOptionsForRuntime(runtime: BuildRuntime, options: ExecOption
}
}
}

// Detect if we are using node v18, since we don't support lower than 18, and we only need to enable the flag for v18
function nodeRuntimeNeedsGlobalWebCryptoFlag(): boolean {
try {
return process.versions.node.startsWith("18.");
} catch {
return false;
}
}
Loading