Add text_pattern_ops index on SecretKey.key to improve getSecrets perf

[ericallam]

Summary by CodeRabbit

• Chores
  • Enhanced backend performance with an optimized index that improves response times for key-based data retrieval.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4879cbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

A new SQL migration script has been added to create an index on the SecretStore table's key column using the text_pattern_ops operator. This index, named "SecretStore_key_idx", is created concurrently to avoid locking the table. The corresponding Prisma schema for the SecretStore model has also been updated to include a BTree index on the key field. No additional changes to other entities or models are present.

Changes

Files	Change Summary
internal-packages/database/prisma/(migrations/.../migration.sql, schema.prisma)	Introduced a concurrent SQL migration that creates the "SecretStore_key_idx" on the SecretStore table using text_pattern_ops on the key column, and updated the Prisma model to include a corresponding BTree index for efficient text pattern matching.

Sequence Diagram(s)

sequenceDiagram
    participant M as Migration Script
    participant DB as Database
    participant P as Prisma Client

    M->>DB: Execute "CREATE INDEX CONCURRENTLY IF NOT EXISTS..."
    DB-->>M: Acknowledge index creation
    P->>DB: Query SecretStore using pattern matching on key
    DB-->>P: Return query results optimized by the new index

Loading

Poem

I'm a rabbit, hopping with glee,
For indexes now guide my query spree.
A shiny index made to last,
Speeding up each search in a flash.
With every bounce and every hop,
I celebrate this change non-stop!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f52b00 and 4879cbc.

📒 Files selected for processing (2)

• internal-packages/database/prisma/migrations/20250203223832_add_text_pattern_ops_index_to_secret_store_key/migration.sql (1 hunks)
• internal-packages/database/prisma/schema.prisma (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• internal-packages/database/prisma/schema.prisma

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

internal-packages/database/prisma/migrations/20250203223832_add_text_pattern_ops_index_to_secret_store_key/migration.sql (1)

1-2: Concurrent Index Creation for Optimized Pattern Searches
The SQL migration script correctly creates an index on the "SecretStore" table's "key" column using the text_pattern_ops operator. Using CONCURRENTLY along with IF NOT EXISTS ensures that the index is built without locking the table and avoids duplicate creation if the index already exists. Please verify that your underlying PostgreSQL version fully supports the CONCURRENTLY clause with the IF NOT EXISTS condition and that the table name ("SecretStore") and column ("key") match those in your Prisma schema changes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

@trigger.dev/build

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1659

trigger.dev

npm i https://pkg.pr.new/triggerdotdev/trigger.dev@1659

@trigger.dev/react-hooks

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1659

@trigger.dev/rsc

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1659

@trigger.dev/core

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1659

@trigger.dev/sdk

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1659

commit: 4879cbc