-
-
Notifications
You must be signed in to change notification settings - Fork 728
Adds Cursor rules for writing Trigger.dev tasks #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA new markdown document has been added at Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant CLI as CLI Tool
participant Env as Environment
participant Engine as Task Engine
Dev->>CLI: Run initialization command
CLI->>Dev: Display setup instructions (env variables, etc.)
Dev->>Env: Configure environment variables
Dev->>CLI: Execute development command
CLI->>Engine: Trigger task execution
Engine->>Engine: Run lifecycle functions (init, onStart, onSuccess, onFailure, handleError)
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.cursor/rules/writing-tasks.mdc (1)
317-317
: Fix typographical error.“Sepcify” should be “Specify” to maintain professionalism and consistency.
-// Sepcify a cron pattern (UTC) +// Specify a cron pattern (UTC)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.cursor/rules/writing-tasks.mdc
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
.cursor/rules/writing-tasks.mdc (2)
15-44
: Commendable clarity on deprecated vs. correct patterns.This section clearly distinguishes which legacy patterns to avoid and which updated approach to adopt. It helps prevent confusion and ensures consistent usage of the new task API from
@trigger.dev/sdk/v3
. Great job documenting these differences in detail.
1248-1270
: Excellent verification steps for AI-generated code.The explicit checklist and consequences for not adhering to these guidelines set a high standard of quality control. This clarity helps ensure that any generated code properly follows the new Trigger.dev v3 task patterns.
New Cursor rules for writing Trigger.dev tasks
The file contains:
Summary by CodeRabbit