Max duration error referenced ms when it should seconds

[matt-aitken]

The Max duration error referenced ms when it should seconds. Improved the test slightly too.

Summary by CodeRabbit

• Bug Fixes

  • Refined error notifications for task timeouts to display compute time in seconds, enhancing clarity when tasks exceed allowed durations.

• Tests

  • Updated test validations to remain consistent with the revised error messaging.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6c67932

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The update refines the error messaging for task execution durations by changing the message text and unit of measurement. The error message now states that the "Run exceeded maximum compute time (maxDuration)" in seconds, replacing the previous millisecond-based message. In addition, test cases have been updated with a renamed variable for consistency. The overall logic and control flow remain unchanged.

Changes

File(s)	Change Summary
packages/core/.../taskExecutor.ts	Updated error message text to change the unit from milliseconds to seconds and rephrase the wording for clarity.
packages/core/test/taskExecutor.test.ts	Renamed variable from maxDurationMs to maxDurationSeconds and updated the expected error message to reflect the new time unit.

Suggested reviewers

• ericallam
• nicktrn

Poem

I'm a tiny rabbit, coding with glee,
Hopping through changes so swiftly and free,
From ms to sec, our messages gleam bright,
With words that now sparkle in the soft moonlight,
Celebrating our code from morning till night! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8977d25 and 6c67932.

📒 Files selected for processing (2)

• packages/core/src/v3/workers/taskExecutor.ts (1 hunks)
• packages/core/test/taskExecutor.test.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests

🔇 Additional comments (4)

packages/core/src/v3/workers/taskExecutor.ts (1)

386-386: Appropriate unit correction for maximum duration.

This change correctly updates the error message to reference seconds instead of milliseconds, which aligns with the actual unit used for maxDuration throughout the system.

packages/core/test/taskExecutor.test.ts (3)

420-420: Variable name corrected to match actual unit.

Good rename from maxDurationMs to maxDurationSeconds to accurately reflect the unit of measurement.

---

442-443: Updated expected error message to match implementation.

Correctly updated the test's expected error message to align with the implementation change.

---

1497-1497: Updated error verification to match new message format.

This update ensures the test verification matches the new error message format from the implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes a bug in the error messaging for task timeouts by changing the displayed unit from milliseconds to seconds and updates the corresponding tests.

• Changed variable naming in tests from maxDurationMs to maxDurationSeconds.
• Updated error messages in both tests and production code to display compute time in seconds.
• Adjusted test validations to match the revised error messaging.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/core/test/taskExecutor.test.ts	Updated test variable and error message to use seconds instead of milliseconds.
packages/core/src/v3/workers/taskExecutor.ts	Updated error message to display max duration in seconds.

Comments suppressed due to low confidence (2)

packages/core/test/taskExecutor.test.ts:1420

• Renaming the variable from ms to seconds without converting the numeric value may lead to incorrect interpretation of the duration. Confirm whether the value should be divided by 1000 to accurately represent seconds.

const maxDurationSeconds = 1000;

packages/core/src/v3/workers/taskExecutor.ts:386

• Ensure that 'maxDuration' represents the duration in seconds; if the original value is in milliseconds, it should be converted accordingly to maintain consistency with the error message.

message: `Run exceeded maximum compute time (maxDuration) of ${maxDuration} seconds`,