Skip to content

Fixes missing truncation on the project name text #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Mar 31, 2025

Fixes the truncation when project names are too long.

Also prevents the dropdown chevron icon getting too small

CleanShot 2025-03-31 at 14 46 46

Summary by CodeRabbit

  • Style
    • Enhanced layout stability by fine-tuning content overflow handling in navigation elements.
    • Adjusted display settings in project selectors to optimize content visibility.
    • Updated icon sizing in popover components for consistent and balanced design.

Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: 7dac680

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Mar 31, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the CSS classes used in two webapp components. In the navigation component (SideMenu.tsx), class names for particular <div> elements have been modified to adjust content overflow behavior. In the popover component (Popover.tsx), the minimum width utility for the DropdownIcon has been updated from a custom rem value to a Tailwind CSS utility class. No changes have been made to any exported or public entity interfaces.

Changes

File(s) Change Summary
apps/webapp/app/components/navigation/SideMenu.tsx In the SideMenu component, added overflow-hidden to a <div>'s class; in the ProjectSelector component, removed overflow-hidden from the PopoverArrowTrigger.
apps/webapp/app/components/primitives/Popover.tsx Updated the DropdownIcon component's class from min-w-[0.75rem] to min-w-4 to utilize a Tailwind CSS utility class for minimum width styling.

Possibly related PRs

Suggested reviewers

  • matt-aitken

Poem

I'm a rabbit in the code, so light,
Hopping through style changes with delight.
Overflow contained here and there,
A tidy layout with CSS flair.
My whiskers twitch at each new tweak,
Celebrating updates sleek and chic! 🐇
Coding carrots make the day bright!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b34dbe and 7dac680.

📒 Files selected for processing (2)
  • apps/webapp/app/components/navigation/SideMenu.tsx (2 hunks)
  • apps/webapp/app/components/primitives/Popover.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit 4d5080d into main Mar 31, 2025
10 of 11 checks passed
@matt-aitken matt-aitken deleted the fix-missing-project-name-trunction branch March 31, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants