-
-
Notifications
You must be signed in to change notification settings - Fork 730
Added the Attempt span error back (and properties) #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe pull request updates the span detail rendering logic in the SpanEntity function. The changes include updating the margin class for the WarmStartCombo component from Changes
Sequence Diagram(s)sequenceDiagram
participant SE as SpanEntity
participant WSC as WarmStartCombo
participant SEvt as SpanEvents
participant CB as CodeBlock
SE->>WSC: Render with class "my-3"
alt If span.events exists
SE->>SEvt: Render SpanEvents
end
alt If span.properties exists
SE->>CB: Render CodeBlock
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I accidentally removed the Attempt span error block when I created the separate component to render attempts… this brings it back
Summary by CodeRabbit