-
-
Notifications
You must be signed in to change notification settings - Fork 729
[V4 beta] batchTrigger
failed if the parent completed before they were queued.
#1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe logic in the triggerTask.server.ts file was updated to refine the validation condition for handling parent runs. Now, a validation error is thrown only when a parent run exists, is in a final state, and the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
We don't want to trigger child runs if the parent is completed and it's a
triggerAndWait
orbatchTriggerAndWait
.The bug here was that we weren't checking that it was a
wait
variant. So if you usedbatchTrigger
with a large batch and the parent run completed, the children wouldn't be triggered…Summary by CodeRabbit