Skip to content

[V4 beta] batchTrigger failed if the parent completed before they were queued. #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

matt-aitken
Copy link
Member

@matt-aitken matt-aitken commented Apr 17, 2025

We don't want to trigger child runs if the parent is completed and it's a triggerAndWait or batchTriggerAndWait.

The bug here was that we weren't checking that it was a wait variant. So if you used batchTrigger with a large batch and the parent run completed, the children wouldn't be triggered…

Summary by CodeRabbit

  • Bug Fixes
    • Improved task triggering behavior to reduce unnecessary validation errors when resuming parent runs, ensuring errors are only shown when appropriate options are set.

Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: ecefd16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 17, 2025

Walkthrough

The logic in the triggerTask.server.ts file was updated to refine the validation condition for handling parent runs. Now, a validation error is thrown only when a parent run exists, is in a final state, and the resumeParentOnCompletion option is explicitly set to true. Previously, the error was thrown for any final-state parent run regardless of this option. No changes were made to exported or public entity declarations.

Changes

File(s) Change Summary
apps/webapp/app/runEngine/services/triggerTask.server.ts Modified the condition for throwing a validation error to require resumeParentOnCompletion to be truthy in addition to the parent run being in a final state. No changes to public or exported entity declarations.

Poem

A hop and a skip, a check in the code,
Only if you wish, will the error explode.
Parent runs resting, but with a flag in the air,
The rabbit ensures validation is fair.
With logic refined, the journey’s more neat,
Bugs in the garden? None to defeat! 🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e501113 and ecefd16.

📒 Files selected for processing (1)
  • apps/webapp/app/runEngine/services/triggerTask.server.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
apps/webapp/app/runEngine/services/triggerTask.server.ts (1)

240-244: Appropriate fix for the batchTrigger bug.

This change correctly addresses the bug where child runs weren't triggered if the parent completed before they were queued. By adding the body.options?.resumeParentOnCompletion condition, the validation error will only be thrown when the parent run exists, is in a final state, AND the trigger variant is a "wait" type (indicated by resumeParentOnCompletion being true).

This ensures that child runs are correctly triggered in non-wait scenarios even if the parent is already completed, which aligns with the expected behavior described in the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit 1b758bd into main Apr 17, 2025
12 checks passed
@matt-aitken matt-aitken deleted the v4-large-batch-trigger-fix branch April 17, 2025 13:25
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants