-
-
Notifications
You must be signed in to change notification settings - Fork 729
Multiple queue consumers and dev engine URL changesets #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e360a0a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update introduces two main changes: First, the "dev" command has been modified to utilize the engine URL provided by the platform, replacing any hardcoded or locally defined URLs. Second, the "@trigger.dev/core" package now supports a configurable queue consumer count within the supervisor session, enabling dynamic adjustment of processing concurrency. Both changes are implemented as patch-level updates, with no modifications to exported or public entity declarations. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant DevCommand
participant Platform
participant Engine
Developer->>DevCommand: Run "dev" command
DevCommand->>Platform: Request engine URL
Platform-->>DevCommand: Return engine URL
DevCommand->>Engine: Connect using platform-provided URL
sequenceDiagram
participant SupervisorSession
participant Config
participant QueueConsumer
SupervisorSession->>Config: Retrieve consumer count setting
loop For each consumer (based on count)
SupervisorSession->>QueueConsumer: Start consumer instance
end
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
.changeset/eighty-rings-divide.md (1)
1-6
:⚠️ Potential issueMissing changeset for the
trigger.dev
package
Per PR objectives, this PR should include two changesets: one for the core package (present here) and one for thetrigger.dev
CLI update (engine URL change). Please add a.changeset/*.md
file describing thetrigger.dev
package bump and summarizing the dev command URL adjustment.Do you need help drafting the second changeset?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/blue-eyes-tickle.md
(1 hunks).changeset/eighty-rings-divide.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.changeset/eighty-rings-divide.md (1)
1-3
: Header syntax looks correct
The YAML‐style header properly specifies a patch bump for@trigger.dev/core
.
Missing changesets for:
Summary by CodeRabbit
New Features
Chores