Skip to content

Multiple queue consumers and dev engine URL changesets #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Apr 18, 2025

Missing changesets for:

Summary by CodeRabbit

  • New Features

    • Added the ability to configure the number of queue consumers in the supervisor session, providing more control over processing concurrency.
  • Chores

    • Updated the development command to use the platform-provided engine URL for improved consistency.

Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: e360a0a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 18, 2025

Walkthrough

This update introduces two main changes: First, the "dev" command has been modified to utilize the engine URL provided by the platform, replacing any hardcoded or locally defined URLs. Second, the "@trigger.dev/core" package now supports a configurable queue consumer count within the supervisor session, enabling dynamic adjustment of processing concurrency. Both changes are implemented as patch-level updates, with no modifications to exported or public entity declarations.

Changes

File(s) Change Summary
.changeset/blue-eyes-tickle.md Updated the "dev" command to use the platform-provided engine URL instead of a hardcoded/local URL.
.changeset/eighty-rings-divide.md Added support for configuring the queue consumer count in the supervisor session for "@trigger.dev/core".
packages/trigger.dev, packages/@trigger.dev/core Applied patch-level updates reflecting the above changes.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant DevCommand
    participant Platform
    participant Engine

    Developer->>DevCommand: Run "dev" command
    DevCommand->>Platform: Request engine URL
    Platform-->>DevCommand: Return engine URL
    DevCommand->>Engine: Connect using platform-provided URL
Loading
sequenceDiagram
    participant SupervisorSession
    participant Config
    participant QueueConsumer

    SupervisorSession->>Config: Retrieve consumer count setting
    loop For each consumer (based on count)
        SupervisorSession->>QueueConsumer: Start consumer instance
    end
Loading

Possibly related PRs

Suggested reviewers

  • matt-aitken

Poem

In the warren of code, a new path is unfurled,
Engine URLs now platform-whirled.
Queue consumers gather, not just one or two—
Configured by need, a scalable crew!
Rabbits rejoice as the dev flow refines,
Hopping ahead in elegant lines.
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🔭 Outside diff range comments (1)
.changeset/eighty-rings-divide.md (1)

1-6: ⚠️ Potential issue

Missing changeset for the trigger.dev package
Per PR objectives, this PR should include two changesets: one for the core package (present here) and one for the trigger.dev CLI update (engine URL change). Please add a .changeset/*.md file describing the trigger.dev package bump and summarizing the dev command URL adjustment.

Do you need help drafting the second changeset?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa74260 and e360a0a.

📒 Files selected for processing (2)
  • .changeset/blue-eyes-tickle.md (1 hunks)
  • .changeset/eighty-rings-divide.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.changeset/eighty-rings-divide.md (1)

1-3: Header syntax looks correct
The YAML‐style header properly specifies a patch bump for @trigger.dev/core.

@nicktrn nicktrn merged commit 0ebecbe into main Apr 18, 2025
6 of 12 checks passed
@nicktrn nicktrn deleted the fix/missing-changesets branch April 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants