Increase v4 visibility timeouts & don't try continue finished runs #1978
Conversation
|
WalkthroughThe changes introduce a new utility function to check if a task run execution status is either "FINISHED" or "PENDING_CANCEL". This function is integrated into the waitpoint system to add an early exit condition, preventing unnecessary processing for runs that are already finished or pending cancellation. Additionally, error logging is improved for missing checkpoints. Separately, the visibility timeout values for several worker tasks in the worker catalog are increased to allow more time for task completion, with no changes to public APIs or logic beyond these configuration updates. Changes
Sequence Diagram(s)sequenceDiagram
participant System as WaitpointSystem
participant Statuses as statuses.ts
System->>Statuses: isFinishedOrPendingFinished(status)
alt Status is finished or pending finished
System-->>System: Log debug message
System-->>System: Return early, skip processing
else Status is not finished/pending finished
System-->>System: Continue normal processing
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧬 Code Graph Analysis (2)internal-packages/run-engine/src/engine/statuses.ts (1)
internal-packages/run-engine/src/engine/systems/waitpointSystem.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request introduces new functionality to handle specific task run statuses, improves error handling in the
WaitpointSystem, and adjusts visibility timeouts in theworkerCatalog. These changes aim to enhance the reliability and maintainability of the run engine.New functionality for task run statuses:
isFinishedOrPendingFinished, to determine if a task run status is either "FINISHED" or "PENDING_CANCEL". This function is now used in theWaitpointSystemto prevent unnecessary processing of completed runs. (internal-packages/run-engine/src/engine/statuses.ts, internal-packages/run-engine/src/engine/statuses.tsR34-R38)Improvements to the
WaitpointSystem:isFinishedOrPendingFinishedfunction in theWaitpointSystemto skip processing for runs that are already finished, improving efficiency. (internal-packages/run-engine/src/engine/systems/waitpointSystem.ts, internal-packages/run-engine/src/engine/systems/waitpointSystem.tsR515-R522)internal-packages/run-engine/src/engine/systems/waitpointSystem.ts, internal-packages/run-engine/src/engine/systems/waitpointSystem.tsR584-R588)Adjustments to visibility timeouts:
workerCatalogto reduce the likelihood of premature task retries. Most timeouts were adjusted from 5,000ms or 10,000ms to 30,000ms, withqueueRunsPendingVersionupdated to 60,000ms. (internal-packages/run-engine/src/engine/workerCatalog.ts, internal-packages/run-engine/src/engine/workerCatalog.tsL9-R54)Summary by CodeRabbit
New Features
Bug Fixes
Chores