allow configuring the replication leader lock settings

[ericallam]

Summary by CodeRabbit

• New Features

  • Added new environment variables to configure the retry count and interval for run replication leader lock attempts.
  • Enhanced service configuration options to allow customization of retry behavior for leader lock acquisition.

• Improvements

  • Error logs for leader lock failures now include retry configuration details for better troubleshooting.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c4b8b75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Two new environment variables for configuring run replication leader lock retry behavior were introduced. These variables are propagated through the service initialization layers and ultimately included in the replication client's error logging context. No control flow or logic was altered beyond extending configuration and logging.

Changes

File(s)	Change Summary
apps/webapp/app/env.server.ts	Added two environment variables: RUN_REPLICATION_LEADER_LOCK_RETRY_COUNT and RUN_REPLICATION_LEADER_LOCK_RETRY_INTERVAL_MS to the schema.
apps/webapp/app/services/runsReplicationInstance.server.ts	Passed new environment variables as configuration options to the replication service initialization.
apps/webapp/app/services/runsReplicationService.server.ts	Extended RunsReplicationServiceOptions type and constructor to accept and use the two new configuration parameters.
internal-packages/replication/src/client.ts	Included retryCount and retryIntervalMs in error logging context for leader lock acquisition failures.

Poem

In the warren where code hops and flows,
Two new numbers now everyone knows—
How often to try, how long to wait,
When leader locks hesitate.
With every retry, the logs now gleam,
A rabbit’s delight in a well-tuned team! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb96e84 and c4b8b75.

📒 Files selected for processing (4)

• apps/webapp/app/env.server.ts (1 hunks)
• apps/webapp/app/services/runsReplicationInstance.server.ts (1 hunks)
• apps/webapp/app/services/runsReplicationService.server.ts (2 hunks)
• internal-packages/replication/src/client.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/webapp/app/services/runsReplicationInstance.server.ts (1)

apps/webapp/app/env.server.ts (1)

• env (774-774)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (5)

apps/webapp/app/env.server.ts (1)

769-770: LGTM! Well-defined configuration variables for leader lock retry.

These new environment variables follow the established naming pattern and have appropriate default values (240 retries and 500ms interval). They'll allow users to configure the retry behavior when acquiring leader locks in the replication system.

internal-packages/replication/src/client.ts (1)

596-597: Good addition to error logging context.

Adding retry configuration details to the error logs will improve diagnostics when leader lock acquisition fails, making it easier to troubleshoot replication issues in production environments.

apps/webapp/app/services/runsReplicationInstance.server.ts (1)

48-49: LGTM! Properly passing environment variables to the service.

The new configuration parameters are correctly passed from environment variables to the RunsReplicationService, maintaining consistent configuration throughout the system.

apps/webapp/app/services/runsReplicationService.server.ts (2)

46-47: LGTM! Well-defined optional parameters in the options interface.

These optional parameters properly extend the service options interface, maintaining type safety and following the established pattern.

---

108-109: LGTM! Consistent default values for the replication client.

The default values here match those defined in the environment schema (240 retries, 500ms interval), ensuring consistency throughout the configuration chain.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.