-
-
Notifications
You must be signed in to change notification settings - Fork 722
Docs: Adds 2 references to the node.js versions we use for v3 and v4 #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samejr
wants to merge
1
commit into
main
Choose a base branch
from
docs-add-node-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Trigger.dev runs your tasks on specific Node.js versions depending on the version you're using: | ||
|
||
- **v3**: Uses Node.js `21.7.3` | ||
- **v4**: Uses Node.js `21.7.3` by default, or Node.js `22.12.0` if you set `runtime: "node-22"` in your `trigger.config.ts` | ||
|
||
In v4, you can specify `runtime: "node-22"` to use Node.js 22 like this: | ||
|
||
```ts trigger.config.ts | ||
import { defineConfig } from "@trigger.dev/sdk/v3"; | ||
|
||
export default defineConfig({ | ||
project: "<project ref>", | ||
// Your other config settings... | ||
runtime: "node-22", // Uses Node.js 22.12.0 | ||
}); | ||
``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix import path in v4 example
The code snippet uses
import { defineConfig } from "@trigger.dev/sdk/v3"
, but since this example demonstrates configuring v4 for Node.js 22, it should import from the new v4 entrypoint (@trigger.dev/sdk
). Otherwise, users upgrading to v4 may be directed to an incorrect import.Please update the snippet as follows:
In docs/snippets/node-versions.mdx around lines 8 to 16, the import statement
uses the v3 SDK path "@trigger.dev/sdk/v3" but the example is for v4
configuration. Update the import to use the v4 entrypoint by changing it to
"import { defineConfig } from '@trigger.dev/sdk';" to ensure users upgrading to
v4 have the correct import path.