Set endpoint URLs to null, instead of deleting them #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matt-aitken
commented
Jan 30, 2024
| @@ -347,6 +350,7 @@ function RerunPopover({ | |||
| <PopoverContent className="flex min-w-[20rem] max-w-[20rem] flex-col gap-2 p-0" align="end"> | |||
| <Form method="post" action={`/resources/runs/${runId}/rerun`} {...form.props}> | |||
| <input {...conform.input(successRedirect, { type: "hidden" })} defaultValue={runsPath} /> | |||
| <input {...conform.input(failureRedirect, { type: "hidden" })} defaultValue={runPath} /> | |||
There was a problem hiding this comment.
If we fail, we redirect back to this page and show an error toast message
nicktrn
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard deleting endpoints has quite a few bad side effects:
This PR changes the behaviour so "deleting" an endpoint actually just sets the URL to null. Most of the changes were to guard against a null URL and not continue.