Skip to content

Fix/autoyield canceled run #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix/autoyield canceled run #890

merged 2 commits into from
Feb 9, 2024

Conversation

matt-aitken
Copy link
Member

Closes #888

If a run has been canceled but is still executing we want to avoid doing any updates to the run. When the executing stops we check if the run is now canceled, if it is then we exit.

@matt-aitken matt-aitken requested a review from ericallam February 8, 2024 16:28
Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 5358029

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken matt-aitken merged commit 7fae67c into main Feb 9, 2024
@matt-aitken matt-aitken deleted the fix/autoyield-canceled-run branch February 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-1926] Auto-yielding a canceled run causes it to resume again
2 participants