Skip to content

feat(middleware-retry): call retry strategy based on value in retryMode #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

trivikr
Copy link
Owner

@trivikr trivikr commented Jun 1, 2021

Issue

Internal JS-2636

Description

Call retry strategy based on value in retryMode.
This PR will be posted upstream when the following PRs are merged:

Testing

Verified that adaptive retry strategy is called when retryMode is passed:

const { DynamoDB } = require("../aws-sdk-js-v3/clients/client-dynamodb");

(async () => {
  const client = new DynamoDB({ retryMode: "adaptive" });
  await client.listTables({ Limit: 1 });
})();

Verified that retryStrategy.mode was "adaptive" in retyMiddleware using console.log


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft June 1, 2021 14:12
@trivikr trivikr force-pushed the strategy-on-retry-mode branch from 6ec25ca to cf2d7af Compare June 1, 2021 20:49
@trivikr trivikr force-pushed the strategy-on-retry-mode branch from cf2d7af to df1e7b1 Compare June 1, 2021 21:10
@trivikr
Copy link
Owner Author

trivikr commented Jun 1, 2021

PR posted upstream at aws#2456

@trivikr trivikr closed this Jun 1, 2021
@trivikr trivikr deleted the strategy-on-retry-mode branch June 1, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant