Skip to content

Add AWS GovCloud Support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

elijahchancey-arena
Copy link
Contributor

AWS GovCloud ARNs follow a different format. They begin with "arn:aws-us-gov". AWS Commercial accounts begin with "arn:aws".

This PR works with both AWS GovCloud & Commercial accounts.

Copy link
Contributor

@golfdish golfdish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it passes the smoke test with the default value. Thanks!

@elijahchancey-arena
Copy link
Contributor Author

Thank you!

@elijahchancey-arena
Copy link
Contributor Author

Do I need to do anything else before it's merged? @avimoondra @golfdish Thanks

@golfdish
Copy link
Contributor

golfdish commented Jun 9, 2025

Nope, should be good to merge as is!

@elijahchancey-arena
Copy link
Contributor Author

Just so you know, I don't have permissions to merge. @golfdish

@golfdish
Copy link
Contributor

Oops, sorry! 😅

@golfdish golfdish merged commit 24c36eb into tryretool:main Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants