Skip to content

Report java sources to KSP #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

yigit
Copy link
Contributor

@yigit yigit commented Jan 15, 2021

This PR fixes a bug where we were not reporting java sources when building ksp arguments.
Failing to add them means getSymbolsAnnotatedWith misses all java sources.

I've also updated KSP to 1.4.20-dev-experimental-20210111

@tschuchortdev tschuchortdev merged commit 0a0af2b into tschuchortdev:master Jan 15, 2021
@tschuchortdev
Copy link
Owner

Thanks!

@yigit
Copy link
Contributor Author

yigit commented Jan 15, 2021

thanks for the merge. I discovered this while moving more Room tests to run with KSP.
Is there a scheduled date for 1.3.5 release?

@tschuchortdev
Copy link
Owner

No, I can release it right now if you want.

@yigit
Copy link
Contributor Author

yigit commented Jan 15, 2021

that would be perfect when you get a chance. we are trying to move existing compilation tests (all are in java) to also run w/ ksp.

@tschuchortdev
Copy link
Owner

I've tried to publish a release but as usual there are problems with the Sonatype Nexus repository. Hopefully it will be available again tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants