Skip to content

User data processor improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2016
Merged

User data processor improvements #17

merged 6 commits into from
Feb 14, 2016

Conversation

tremby
Copy link
Contributor

@tremby tremby commented Feb 12, 2016

This is a collection of patches which improve the user data processor, both in documentation and features.

The main changes other than documentation are these:

  • Add an appends option, which allows extra fields from the user to be added, even if they were not part of the user object's toArray return value. This is sometimes useful to include a field which is useful when debugging errors but which is not normally needed when getting data about a user, for example when sending it as JSON via ajax responses.
  • Change how the data is passed to Sentry. Sentry shows only particular user data keys (id, username, email, ip_address) and treats them specially (giving them formatted names and a Gravatar for email address). It doesn't show any other user data unless the values are part of a data substructure. This patch makes all of the passed fields visible in Sentry.

This option allows extra fields from the User object to be attached to
error reports.
Sentry treats 'id', 'username', 'email', and 'ip_address' specially,
displaying only these. It displays other keys only if they're within a
'data' substructure.

See the relevant Sentry source at
https://github.com/getsentry/sentry/blob/e7a295784f10a296ace7aa98e1b7216328feac5d/src/sentry/interfaces/user.py#L31
@pulkitjalan pulkitjalan merged commit 08e5d5e into twine-net:master Feb 14, 2016
@pulkitjalan
Copy link
Contributor

Thanks!

@tremby tremby deleted the user-data-processor-improvements branch February 15, 2016 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants