Add locale processor #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can no longer be merged :( |
This processor adds a tag 'locale' with the app's current locale to an outgoing report.
|
Yes, that was expected, since they both added the same section to the readme, but with different subsections. I've rebased this, and it should merge now. |
|
Great, Thanks! |
|
No problem. If you're happy with these two, a release would be great. I also commented on an earlier commit a couple of days ago; did you see that? Not a huge deal. |
|
Done, yea its now fixed. That was an accident, i was suppose to move it into the data array init. Done that now. Thanks. |
|
Okay, I'm going to put the doc comment about that back in, then. Expect another PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This processor adds a tag 'locale' with the app's current locale to an outgoing report.