Add permissions.OperandHolder to decorators.permission_classes signature #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Aug 3, 2021
|
oh yes, on it. |
|
would a test like this suffice ? |
sobolevn
reviewed
Aug 3, 2021
|
|
||
| - case: permission_classes | ||
| main: | | ||
| from rest_framework.decorators import permission_classes |
There was a problem hiding this comment.
We need to test that & form works. You can also add tests for other ways if
- they are missing
- you have the time for it 🙂
|
i can add more tests if you have something else in mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this will allow
permission_classesto accept types likeBasePermission & BasePermission.i am not sure if i should import
_PermissionsClassesas defined in the permissions stub and remove the preceding underscore, feedback is appreciated.