Allow to prevent shortcuts processing in onKeyDown by returning false #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to prevent shortcuts processing in onKeyDown by returning false
|
❌ Deploy Preview for vibrant-wilson-a6f337 failed. 🔨 Explore the source changes: be999d6 🔍 Inspect the deploy log: https://app.netlify.com/sites/vibrant-wilson-a6f337/deploys/61f100c0c3d600000764a057 |
|
Oh I see the onKeyDown type needs to be changed as well. |
jaywcjlove
added a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I need the functionality to "submit" the code when the user presses cmd+enter on Mac or ctrl+enter on Windows. I could "submit" in the onKeyDown but the combination would insert the enter plus indention.
Now the user can return false from onKeyDown to prevent the shortcut processing.
Sorry if the format of this pull request is wrong, it's one of my first ever :)