feat(devin-lang): refactor process handling in RunConfigurationProfileState #101

Improve the process handling logic in RunConfigurationProfileState to use detaching instead of destroying the

Author: phodal

exts/devin-lang/src/main/kotlin/cc/unitmesh/devti/language/run/AutoDevRunConfigurationProducer.kt

@@ -31,7 +31,7 @@ class AutoDevRunConfigurationProducer : LazyRunConfigurationProducer<AutoDevConf
         val psiLocation = context.psiLocation ?: return false
         val psiFile = psiLocation.containingFile as? DevInFile ?: return false
         val virtualFile = psiFile.virtualFile ?: return false
-        val scriptPath = configuration.getScriptPath() ?: return false
+        val scriptPath = configuration.getScriptPath()
 
         return virtualFile.path == scriptPath
     }

exts/devin-lang/src/main/kotlin/cc/unitmesh/devti/language/run/DevInRunConfigurationProfileState.kt

@@ -14,13 +14,7 @@ import com.intellij.execution.runners.ProgramRunner
 import com.intellij.execution.ui.ConsoleView
 import com.intellij.execution.ui.ConsoleViewContentType
 import com.intellij.openapi.project.Project
-import com.intellij.openapi.util.io.StreamUtil
-import java.io.BufferedInputStream
-import java.io.BufferedOutputStream
-import java.io.InputStream
 import java.io.OutputStream
-import java.nio.channels.Channels
-import java.nio.channels.Pipe
 
 open class DevInRunConfigurationProfileState(
     private val myProject: Project,
@@ -33,62 +27,34 @@ open class DevInRunConfigurationProfileState(
         val console: ConsoleView = ConsoleViewWrapperBase(ConsoleViewImpl(myProject, true))
 
         console.attachToProcess(processHandler)
-        processHandler.startNotify()
 
         console.print("Hello, World!", ConsoleViewContentType.NORMAL_OUTPUT)
-        processHandler.destroyProcess()
 
-        return DefaultExecutionResult(console, processHandler)
+        // done!
+        processHandler.detachProcess()
+
+        val result = DefaultExecutionResult(console, processHandler)
+
+        return result
     }
 
     @Throws(ExecutionException::class)
     private fun createProcessHandler(myExecutionName: String): ProcessHandler {
         return object : BuildProcessHandler() {
-            var myProcessInputWriter: OutputStream? = null
-            var myProcessInputReader: InputStream? = null
-
-            init {
-                val pipe = Pipe.open()
-
-                myProcessInputWriter = BufferedOutputStream(Channels.newOutputStream(pipe.sink()))
-                myProcessInputReader = BufferedInputStream(Channels.newInputStream(pipe.source()))
-            }
-
             override fun detachIsDefault(): Boolean = false
 
             override fun destroyProcessImpl() {
-                try {
-                    // cancel myTask
-                    // myTask?.cancel()
-                } finally {
-                    closeInput()
-                }
-
-                // execute default process destroy
-                super.destroyProcess()
             }
 
             override fun detachProcessImpl() {
-                try {
-                    notifyProcessDetached()
-                } finally {
-                    closeInput()
-                }
-
-                super.detachProcess()
+                notifyProcessTerminated(0);
             }
 
-            override fun getProcessInput(): OutputStream? = myProcessInputWriter
+            override fun getProcessInput(): OutputStream? = null
             override fun getExecutionName(): String = myExecutionName
 
             protected fun closeInput() {
-                val processInputWriter = myProcessInputWriter
-                val processInputReader = myProcessInputReader
-                myProcessInputWriter = null
-                myProcessInputReader = null
 
-                processInputWriter?.close()
-                processInputReader?.close()
             }
         }
     }