修改自定义模型stream字段类型非boolean类型时，访问异常。 #361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary stream priority check and added condition to handle boolean stream values in custom fields. - Ensures that the stream parameter is only overridden if it is not already a boolean value in custom
iptton
reviewed
Apr 2, 2025
| put("stream", stream) | ||
| val streamInCustomFields = customFields.jsonObject.get("stream") | ||
| if (streamInCustomFields == null || streamInCustomFields.jsonPrimitive.booleanOrNull == true || streamInCustomFields.jsonPrimitive.booleanOrNull == false) { | ||
| // stream 参数优先级高于 customFields.stream |
There was a problem hiding this comment.
// stream 参数优先级高于 customFields.stream
这个函数的设置是参数优先级高于 json 字段，现在这样改至少和之前的设计不一致了。建议找上游调用侧，哪里传了 stream = true 进来，又或者把优先级相关的注释改掉
There was a problem hiding this comment.
由于最新的 UI 项中已没有了 SSE 的设置，建议把 stream 参数去掉，不允许强制设置 stream ，而全由 json 设置
There was a problem hiding this comment.
嗯 之前测试的就是直接去掉了。后来担心这段逻辑可能有特殊意义，所以就修改了下。
“建议把 stream 参数去掉，不允许强制设置 stream ，而全由 json 设置” 这个是合理，custom是什么就用什么。
…Processor - Removed the unnecessary stream priority check and added a condition to handle boolean stream values in custom fields. - Ensures that the stream parameter is only overridden if it is not already a boolean value in custom fields, aligning with issue
|
我改了，别瞎 merge ，导致合并不上 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.