Skip to content

feat!: do not create wrap single chars in parentheses #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 24, 2022

resolves #28

BREAKING CHANGE: single chars chained with times, times.any(), times.atLeast(), times.between() and .optionally(), as well as single inputs passed in to oneOrMore and maybe will no longer be wrapped in brackets

@danielroe danielroe added the enhancement New feature or request label Jul 24, 2022
@danielroe danielroe self-assigned this Jul 24, 2022
@vercel
Copy link

vercel bot commented Jul 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
magic-regexp ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 1:51PM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #27 (c6e07b6) into main (fa09325) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          323       350   +27     
  Branches        80        83    +3     
=========================================
+ Hits           323       350   +27     
Impacted Files Coverage Δ
src/core/inputs.ts 100.00% <100.00%> (ø)
src/core/internal.ts 100.00% <100.00%> (ø)
src/core/wrap.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa09325...c6e07b6. Read the comment docs.

@danielroe danielroe merged commit a02645b into main Jul 24, 2022
@danielroe danielroe deleted the feat/reduce-anon-groups branch July 24, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No creation of unneeded groups, e.g. (.)+
2 participants