Skip to content

Fixes an issue where empty values were treated as null values and vica versa #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

fabianfett
Copy link
Collaborator

@fabianfett fabianfett commented Feb 26, 2021

Fix encoding and decoding optional values to and from the database due to a regression in #135. Resolves #143 (#144)

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xTim 0xTim merged commit fa93d76 into vapor:master Feb 26, 2021
@tanner0101
Copy link
Member

These changes are now available in 1.5.1

1 similar comment
@tanner0101
Copy link
Member

These changes are now available in 1.5.1

@fabianfett fabianfett deleted the ff-fix-empty-string branch February 26, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Could not convert to String: <null>" error with empty strings
3 participants