Skip to content

Add link to our SECURITY.md #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

Add link to our SECURITY.md #164

merged 1 commit into from
Jun 16, 2021

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Jun 16, 2021

To comply with new SSWG guidelines

fabianfett
fabianfett approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@fabianfett fabianfett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However there is also a Security.md in this repo, which is good because it is linked to by GitHub (Security tab). Are we sure in this case that we want to link out to the vapor main repo?

@0xTim
Copy link
Member Author

0xTim commented Jun 16, 2021

@fabianfett where's the security.md in this repo? I couldn't see it. It should be the one in vapor/.github which gets linked to all repos

@fabianfett
Copy link
Collaborator

Ah! TIL. Okay. All green!

@0xTim 0xTim merged commit 8527fef into main Jun 16, 2021
@0xTim 0xTim deleted the add-security branch June 16, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

@siemensikkema siemensikkema Awaiting requested review from siemensikkema

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTim @fabianfett