-
-
Notifications
You must be signed in to change notification settings - Fork 82
Splits CI Jobs Into Unit And Integration Tests On Linux #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this - this is an awesome start! We definitely need to expand the testing to more OSes. I'll let @gwynne chime in as well since she's been overhauling the rest of our CI
- swift:5.3 | ||
- swift:5.4 | ||
- swiftlang/swift:nightly-5.5 | ||
- swiftlang/swift:nightly-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has traditionally caused issues with our CI as we find that bugs in nightly cause our tests to fail and block PRs. I think it would be good to have a separate workflow that runs daily that tests the nightlies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I was working on last time I had a chance to deal with the CI for more than trivial updates, yeah.
- name: Check out code | ||
uses: actions/checkout@v2 | ||
- name: Run tests with Thread Sanitizer | ||
run: swift test --enable-test-discovery --sanitize=thread --filter=^PostgresNIOTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's worth trying to run these tests in parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything that connects to the database can't run in parallel unless we start having tests generate randomly-named databases (or at least schemas).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PostgresNIOTests don't touch a real DB they're all in the integration tests
This was prepared by #157.
CI now also uses more swift compiler versions, namely
5.4
,nightly-5.5
andnightly-main
.It also removes
amazonlinux2
and now only tests onfocal
.fixes #165