Skip to content

Splits CI Jobs Into Unit And Integration Tests On Linux #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 18, 2021

Conversation

dnadoba
Copy link
Contributor

@dnadoba dnadoba commented Aug 12, 2021

This was prepared by #157.
CI now also uses more swift compiler versions, namely 5.4, nightly-5.5 and nightly-main.
It also removes amazonlinux2 and now only tests on focal.

fixes #165

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this - this is an awesome start! We definitely need to expand the testing to more OSes. I'll let @gwynne chime in as well since she's been overhauling the rest of our CI

- swift:5.3
- swift:5.4
- swiftlang/swift:nightly-5.5
- swiftlang/swift:nightly-main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has traditionally caused issues with our CI as we find that bugs in nightly cause our tests to fail and block PRs. I think it would be good to have a separate workflow that runs daily that tests the nightlies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I was working on last time I had a chance to deal with the CI for more than trivial updates, yeah.

- name: Check out code
uses: actions/checkout@v2
- name: Run tests with Thread Sanitizer
run: swift test --enable-test-discovery --sanitize=thread --filter=^PostgresNIOTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth trying to run these tests in parallel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that connects to the database can't run in parallel unless we start having tests generate randomly-named databases (or at least schemas).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PostgresNIOTests don't touch a real DB they're all in the integration tests

@0xTim 0xTim requested a review from gwynne August 16, 2021 07:25
@0xTim 0xTim merged commit 6f6ec7b into vapor:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI for wider test coverage
3 participants