Skip to content

Fix NIO imports #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix NIO imports #171

merged 1 commit into from
Aug 18, 2021

Conversation

fabianfett
Copy link
Collaborator

Motivation

  • SwiftNIO 2.32.0 introduces explicit modules for its Core and Posix.
  • To write great platform independent code in most parts we should only ever import NIOCore

Changes

  • This pr explicitly imports NIOCore, NIOPosix and NIOEmbedded where needed.

@fabianfett fabianfett requested review from gwynne and 0xTim August 18, 2021 07:45
### Motivation

- SwiftNIO 2.32.0 introduces explicit modules for its Core and Posix.
- To write great platform independent code in most parts we should only ever import `NIOCore`

### Changes

- This pr explicitly imports NIOCore, NIOPosix and NIOEmbedded where needed.
@fabianfett fabianfett merged commit 08c0dc5 into vapor:main Aug 18, 2021
@fabianfett fabianfett deleted the ff-fix-imports branch August 18, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants