Extract PSQLRow #177
Merged
Extract PSQLRow #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #135, I did some naming things just wrong.
PSQLRowsis a stupid name. We should name itPSQLRowStream.PSQLRows.Rowis a stupid name for a single table row. We should name itPSQLRow. Transforming an incoming data row packet to a[PSQLData]array early is expensive and stupid. Let's not do this anymore.Changes
Consume this pr in the three change steps (separate commit for each):
PSQLRows.RowtoPSQLRows(Got its own file). Stop the early[PSQLData]madness.PSQLRowstoPSQLRowStreamPSQLRowStreamResult
I feel less embarrassed about my code. It might be a little faster.