-
-
Notifications
You must be signed in to change notification settings - Fork 82
Add PostgresCell #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgresCell #220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 43.19% 48.10% +4.91%
==========================================
Files 119 119
Lines 8210 8243 +33
==========================================
+ Hits 3546 3965 +419
+ Misses 4664 4278 -386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one concern, I don't see anything that needs changing... is there a more specific reason to keep this PR separate other than general desire to cut down on large PRs? (A worthy goal, to be sure!)
ecfd5db
to
4b759b1
Compare
4b759b1
to
2ab772b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge away!
ed5f306
to
2c86c18
Compare
Motivation
In #219 we want to restructure PostgresRow and introduce PostgresRandomAccessRow. To make it very explicit, it would be cool if
PostgresRow
was implementingCollection
andPostgresRandomAccessRow
was implementingRandomAccessCollection
. However to do this we need an Element type. This is whatPostgresCell
shall be.Changes
PostgresCell
PSQLData
Result
We have an awesome Element type for PostgresRow.