Skip to content

Rename PSQLRowSequence to PostgresRowSequence #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

fabianfett
Copy link
Collaborator

Motivation

Same as #224 and #225.

Changes

  • Rename PSQLRowSequence to PostgresRowSequence

@fabianfett fabianfett requested a review from gwynne February 21, 2022 08:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #226 (6bc37e6) into main (3d5d25f) will increase coverage by 4.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   39.10%   43.19%   +4.08%     
==========================================
  Files         121      121              
  Lines        9315     9322       +7     
==========================================
+ Hits         3643     4027     +384     
+ Misses       5672     5295     -377     
Flag Coverage Δ
unittests 43.19% <100.00%> (+4.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/New/PSQLRowStream.swift 84.54% <100.00%> (+6.96%) ⬆️
Sources/PostgresNIO/New/PostgresRowSequence.swift 89.73% <100.00%> (ø)
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.68% <0.00%> (+1.06%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
Sources/PostgresNIO/New/PSQLConnection.swift 30.00% <0.00%> (+2.10%) ⬆️
...s/PostgresNIO/Message/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <0.00%> (+3.22%) ⬆️
...s/PostgresNIO/New/Data/Float+PostgresCodable.swift 76.66% <0.00%> (+3.33%) ⬆️
... and 22 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<no review message was provided; only a disturbance, as if a thousand repetitions of a sequence of letters suddenly cried out in terror and were shoved into a pull request...>

(Don't look at me like that, I've been awake long enough to keep making silly jokes in PR reviews in the first place, it wouldn't be any fun if they were good jokes 😅 Besides, they're good PRs; the work getting done is phenomenal ❤️.)

@fabianfett fabianfett merged commit c98c808 into vapor:main Feb 21, 2022
@fabianfett fabianfett deleted the ff-rename-PSQLRowSequence branch February 21, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants