Skip to content

Rename PSQLEncodingContext to PostgresEncodingContext #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

fabianfett
Copy link
Collaborator

See #224, #225

@fabianfett fabianfett requested a review from gwynne February 22, 2022 00:33
@fabianfett fabianfett force-pushed the ff-rename-PostgresEncodingContext branch from cb634fe to 0b5b9f0 Compare February 22, 2022 00:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #227 (0b5b9f0) into main (c98c808) will increase coverage by 4.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   39.10%   43.19%   +4.08%     
==========================================
  Files         121      121              
  Lines        9315     9322       +7     
==========================================
+ Hits         3643     4027     +384     
+ Misses       5672     5295     -377     
Flag Coverage Δ
unittests 43.19% <ø> (+4.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.68% <ø> (+1.06%) ⬆️
...es/PostgresNIO/New/Data/Bool+PostgresCodable.swift 95.34% <ø> (+4.65%) ⬆️
...s/PostgresNIO/New/Data/Bytes+PostgresCodable.swift 73.52% <ø> (ø)
...es/PostgresNIO/New/Data/Date+PostgresCodable.swift 89.28% <ø> (ø)
...PostgresNIO/New/Data/Decimal+PostgresCodable.swift 74.19% <ø> (+6.45%) ⬆️
...s/PostgresNIO/New/Data/Float+PostgresCodable.swift 76.66% <ø> (+3.33%) ⬆️
...ces/PostgresNIO/New/Data/Int+PostgresCodable.swift 30.71% <ø> (+5.22%) ⬆️
...es/PostgresNIO/New/Data/JSON+PostgresCodable.swift 100.00% <ø> (ø)
...ostgresNIO/New/Data/Optional+PostgresCodable.swift 83.33% <ø> (ø)
...IO/New/Data/RawRepresentable+PostgresCodable.swift 82.35% <ø> (ø)
... and 35 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'll never understand is where you find the hours in the day to make these kinds of changes, Fabian. It must take you forever to do all this! :trollface:

@fabianfett fabianfett merged commit 7f53867 into vapor:main Feb 25, 2022
@fabianfett fabianfett deleted the ff-rename-PostgresEncodingContext branch February 25, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants